question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Identity] Upgrade all of our packages to to use 2.0.1 of @azure/identity

See original GitHub issue

Richard Park started doing this in his PR. I’m aware that there’s a circular dependency issue that I was able to spot due to storage-blob. This is about doing rush add -p @azure/identity@2.0.1--make-consistent in one of the packages that depends on identity and to fix any issues that might arise.

There are some issues that we’re aware of that need to be resolved per package:

  • tenantId now can’t be an invalid tenantId, so use the recorder’s replaceableVariables to set one like 12345678-1234-1234-1234-123456789012.
  • Re-record the NodeJS tests, since MSAL does some more recordings (one of them being that they verify that the Identity endpoint is available, which is something our previous Identity client didn’t do).

If you find any issues while upgrading, please report them in this issue.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

2reactions
sadasantcommented, Nov 9, 2021

Upgrade order for the Azure SDK for JS packages to use the latest Identity:

I believe we should first go with the easy to update projects, then hard to update projects, then Identity manual tests, then samples across the repo. This is to ensure we can capture as many bugs as possible.

Easy to update projects (Re-recording needed)

Packages that have Identity as a dependency, but don’t use it

We should probably just remove Identity from the package.json of these projects.

  • storage-queue.
  • storage-blob-changefeed.
  • core-amqp.

Projects to be updated by project owners (Re-recording needed)

You can pick this up too if you know what is needed to record these. They might be just unfamiliar to me.

Projects to be updated by project owners (No re-recordings needed)

These use Identity but don’t have recordings.

Perf-tests

Fixing these should be about updating the package.json in the sample folders, but I believe we should only do them after the main clients are updated. Updating identity in the samples and the perf-tests should be very straightforward since there are no recordings.

  • perf-tests/search-documents.
  • perf-tests/keyvault-certificates.
  • perf-tests/keyvault-secrets.
  • perf-tests/keyvault-keys.
  • perf-tests/ai-form-recognizer.
  • perf-tests/text-analytics.

Identity-specific sub-projects

These are easy to update, but the other clients are a bigger priority, in my opinion.

  • perf-tests/identity.
  • perf-tests/identity.
  • identity/test/manual-integration/Kubernetes.
  • identity/test/manual-integration/Cloudshell.
  • identity/test/manual-integration/webjobs/App_Data/jobs/triggered/AzureTestJob.
  • identity/test/manual-integration/AzureVM.
  • identity/test/manual.

Samples

  • identity/samples.
  • service-bus/samples.
  • container-registry/samples/v1.
  • event-hubs/samples/browserSample.
  • storage-queue/samples.
  • storage-blob/samples.
  • search-documents/samples.
  • schema-registry/samples/v1.
  • schema-registry-avro/samples/v1.
  • monitor-opentelemetry-exporter/samples/@azure/storage-blob.
  • iot-device-update/samples.
  • app-configuration/samples/v1.
  • keyvault-certificates/samples.
  • keyvault-secrets/samples.
  • keyvault-keys/samples.
  • keyvault-admin/samples.
  • ai-form-recognizer/samples/v3.
  • ai-form-recognizer/samples/v3-beta.
  • ai-text-analytics/samples/v5.
  • template/samples/v1.
  • communication-chat/samples.
  • communication-sms/samples/v1.
  • communication-identity/samples/v1.
  • digital-twins-core/samples/v1. - https://github.com/Azure/azure-sdk-for-js/issues/15712
  • quantum-jobs/samples.
1reaction
ramya-rao-acommented, Nov 16, 2021

Yay! Thanks for all the follow ups @KarishmaGhiya!

Read more comments on GitHub >

github_iconTop Results From Across the Web

aad-pod-identity 2.0.1 - Artifact Hub
Deploy components for aad-pod-identity. ... A simple helm chart for setting up the components needed to use Azure ... Upgrading from chart version...
Read more >
Managed identities - Azure App Service - Microsoft Learn
A managed identity from Azure Active Directory (Azure AD) allows your app to easily access other Azure AD-protected resources such as Azure Key ......
Read more >
@azure/identity - npm
Migrate from v1 to v2 of @azure/identity · Currently supported environments · Install the package · Prerequisites · When to use @azure/identity.
Read more >
Azure.Identity 1.8.0 - NuGet
See the version list below for details. .NET CLI; Package Manager; PackageReference; Paket CLI; Script & Interactive; Cake. dotnet add package ...
Read more >
azure-identity - PyPI
See the Credential classes section below for a list of this library's ... To use the async credentials in azure.identity.aio, you must first...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found