question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[service-bus] Move peekLock/receiveAndDelete flag into `options`

See original GitHub issue

As part of of our API consistency we want to move the lockmode parameter to be part of the options bag (with the default value being 'peekLock`).

This parameter in the signature is currently used to provide some nice type safety (via Receiver<ReceivedMessageWithLock|ReceivedMessage>) which should be preserved when we move the parameter.

In addition we just want to make sure that the doc for the method also calls out that the default lock mode is peekLock. Other languages will be doing something similar so we can coordinate and steal/give them our text as well.

(this is also a good time for us to review the readme and make sure we’re clearly talking about and showing the locking methods in all snippets).

Otherwise, this is just a simple cosmetic change.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
ramya-rao-acommented, Aug 6, 2020

Closing with #10102

0reactions
HarshaNallurucommented, Aug 5, 2020

for proposal 7 75a7c5d as having an overload with no options for createSessionReceivers() takes away the attention not just from receiveMode, but from sessionId as well.

I did think of it, we can decouple CreateSessionReceiverOptions from CreateReceiverOptions<ReceiveMode>, the first two overloads would have BaseCreateSessionReceiverOptions(the older CreateSessionReceiverOptions), the next 4 overloads would include the CreateSessionReceiverOptions<ReceiveMode> (type CreateSessionReceiverOptions<ReceiveMode> = BaseCreateSessionReceiverOptions & CreateReceiverOptions<ReceiveMode>)

For Proposal 6, can you add a comment on that commit with screenshots of how the docs and the editor suggestion s would look like?

Added https://github.com/Azure/azure-sdk-for-js/commit/699e2dac8362315e0dc6535f325c0a0b9ac4cf59#r41219866

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found