Update BlockBlobClient.uploadStream to use NodeJS.ReadableStream instead of Readable

• Package Name: storage-blob
• Package Version: 12
• Operating system: mac
• nodejs
  • version: 14
• browser
  • name/version:
• typescript
  • version: 4
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug Due to this method using Readable type rather than NodeJS.ReadableStream type I cannot pass a standard Node.js readable stream. With this change, users can still pass Readable types to the method since it implements NodeJS.ReadableStream.

I previously tried to fix this with https://github.com/Azure/azure-sdk-for-js/pull/11483 but didn’t anticipate other methods require the Readable type. Maybe i misunderstand the difference between it and NodeJS.ReadableStream. In addition, maybe I need to do something in my own code.

In my specific instance I’m using Node.js and Busboy which defines its file type as NodeJS.ReadableStream (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/busboy/index.d.ts#L41)

[jiacfan]

Hey, @Ethan-Arrowood

Thanks for reaching us and good to know you have found the right approach. Yes, according to Readable’s definition, using wrap is the right approach. This is a valuable topic related to old vs new stream, and might help others as well.

Thanks, Jiachen

[jiacfan]

Close the issue as it’s a node.js usage related pattern and welcome feedback if anyone hit similar isse.