Upload blob runtime error

• Package Name: @azure/storage-blob
• Package Version: ^12.10.0
• Operating system: Ubuntu 20.04.4 LTS
• nodejs
  • version: v14.18.2
• browser
  • name/version:
• typescript
  • version:
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug Got error Error: body must be a string, Blob, ArrayBuffer, ArrayBufferView, or a function returning NodeJS.ReadableStream. Although console.log(`blob instanceof Blob: ${blob instanceof Blob}`); outputs blob instanceof Blob: true, and console.log(blob); output Blob { size: 22, type: 'application/json' } To Reproduce Run following code using node index.js. index.js:

const connStr = ".....";
const { BlobServiceClient } = require("@azure/storage-blob");
const { performance } = require('perf_hooks');
const { Blob } = require('buffer');

const blobServiceClient = BlobServiceClient.fromConnectionString(connStr);

const containerName = "newcontainer1653680240090";
async function main() {
    const start = performance.now();
    const containerClient = blobServiceClient.getContainerClient(containerName);
    const obj = { hello: 'world' };
    const blob = new Blob([JSON.stringify(obj, null, 2)], { type: 'application/json' });
    console.log(`blob instanceof Blob: ${blob instanceof Blob}`);
    console.log(blob);
    const blobName = "newblob" + new Date().getTime();
    const blockBlobClient = containerClient.getBlockBlobClient(blobName);
    await blockBlobClient.upload(blob, blob.size);
    console.log(performance.now() - start);
}

main();

Sample package.json:

{
  "name": "AzureBlobTest",
  "version": "1.0.0",
  "description": "performance test",
  "main": "index.js",
  "author": "Xin Zhang",
  "license": "MIT",
  "dependencies": {
    "@azure/storage-blob": "^12.10.0"
  }
}

Expected behavior The blob should be uploaded without error

Screenshots

Additional context N/A

[zhangxin511]

@xirzec Thanks for replying. I was trying to get some performance analysis for request body using different types between string, stream, ArrayBuffer, blob and noticed this.

If I read the code correctly, eventually everything was serialized to string so using a string body is most efficient, especially the item I want to save is already a string?

[xirzec]

This error is from core-http. We might need some fix in core as well. https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-http/src/serializer.ts#L425

Since the check given is typeof Blob === "function" || typeof Blob === "object") && value instanceof Blob) perhaps you could cheese the logic by making the constructor global? Something like global.Blob = Blob ?