[BUG] HttpMessage.Properties not accessible anymore after dispose.

Library name and version

Azure.Core 1.30.0

Describe the bug

Hello,

This commit https://github.com/Azure/azure-sdk-for-net/commit/437d4ad07ed5580aa8aac690701c05a62d18049b broke our usage of HttpPipeline in our tests:

We use a fake transport to catch all message sent through the HttpPipeline, then in the asserts we check if the received message are what we are expecting.

With this changes the _propertyBag is disposed and then it’s impossible to access the properties anymore.

Expected behavior

Property should be accessible or we should have a way to copy all of them in the transport layer, maybe with a way to list all keys so we can make a copy of it.

Actual behavior

Property are note available anymore

Reproduction Steps

Capture message with an HttpPipelineTransport and try to access the properties after the Dispose

public class FakeTransport : HttpPipelineTransport
{
	private readonly List<FakeRequest> _requests = new List<FakeRequest>();
	private readonly List<HttpMessage> _receivedMessages = new List<HttpMessage>();
	public IReadOnlyList<HttpMessage> ReceivedMessages => _receivedMessages;
	public IReadOnlyList<FakeRequest> CreatedRequests => _requests;
	public Action<HttpMessage>? OnProcess { get; set; }

	public FakeTransport()
	{
		OnProcess = httpMessage =>
			httpMessage.Response = new FakeResponse(418, "OnProcess must be override in tests that directly need to control the response ");
	}

	public override void Process(HttpMessage message)
	{
		OnProcess?.Invoke(message);
		_receivedMessages.Add(message);
	}

	public override ValueTask ProcessAsync(HttpMessage message)
	{
		OnProcess?.Invoke(message);
		_receivedMessages.Add(message);
		return new ValueTask();
	}

	public override Request CreateRequest()
	{
		var request = new FakeRequest();
		_requests.Add(request);
		return request;
	}
}

Environment

No response

[Socolin]

I re-read the code and I saw the overload SetProperty(Type type, object value)

So if I understand correctly, the Dictionary is kind of the “slow” way with string and for performance we should use like a class, and store the property as an object.

So Keys does not really exists, there are 2 kind of keys and since the TypeHandle is stored in one case I think it would be complex to get the list back.

I found a simple way to fix my problem and keep the test as I want them (arrange/act/assert).

Thanks for the explanations.

[christothes]

Yes, there is a dictionary, but it is only referenced inside the array, as you pointed out. Also, this is an internal implementation detail that could also change in the future (as it did in this case ). Unfortunately, the property bag is a resource owned by the type that must be cleaned up on disposal.