Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BUG] Passing BinaryData to BlobClient.UploadAsync() results in NullReferenceException when also using ClientSideEncryptionOptions

See original GitHub issue

Library name and version

Azure.Storage.Blobs 12.10.0.0

Describe the bug

FAILS: Uploading with string content wrapped in BinaryData.

string content = "foo-bar";
BlobClient client;
// not shown here - create BlobClient using SpecializedBlobClientOptions and ClientSideEncryption
await client.UploadAsync(new BinaryData(content), true); // <-- explodes violently, and with its last breath exclaims "Object reference not set to an instance of an object."

Stack trace:

   at Azure.Storage.Blobs.BlobClient+<StagedUploadInternal>d__41.MoveNext (Azure.Storage.Blobs, Version=12.10.0.0, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Storage.Blobs.BlobClient+<UploadAsync>d__37.MoveNext (Azure.Storage.Blobs, Version=12.10.0.0, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)

WORKAROUND: Convert BinaryData to Stream.

await client.UploadAsync(new BinaryData(content).ToStream(), true);

OTHER: When not using ClientSideEncryptionOptions this issue does not occur.

Expected behavior

Result of passing BinaryData is equal to result of passing Stream (blob is uploaded successfully).

Actual behavior

NullReferenceException is thrown in the face of an otherwise happy developer.

Reproduction Steps

// running in app service

// common
var connectionString = Environment.GetEnvironmentVariable("AzureWebJobsStorage");

// for blob encryption
var credential = new Azure.Identity.ManagedIdentityCredential(Environment.GetEnvironmentVariable("APP_IDENTITY_ID"));
var keyResolver = new Azure.Security.KeyVault.Keys.Cryptography.KeyResolver(credential);
var key = keyResolver.Resolve(new Uri(Environment.GetEnvironmentVariable("VAULT_KEY_URI")));
var encryptionOptions = new Azure.Storage.ClientSideEncryptionOptions(Azure.Storage.ClientSideEncryptionVersion.V1_0)
{
    KeyEncryptionKey = key,
    KeyResolver = keyResolver,
    KeyWrapAlgorithm = Environment.GetEnvironmentVariable("VAULT_KEY_WRAP_ALGORITHM")
};

// get encrpyted blob client
var options = new Azure.Storage.Blobs.Specialized.SpecializedBlobClientOptions() { ClientSideEncryption = encryptionOptions };
var serviceClient = new Azure.Storage.Blobs.BlobServiceClient(connectionString, options);
var containerClient = serviceClient.GetBlobContainerClient("repro");
containerClient.CreateIfNotExists();
var blobClient = containerClient.GetBlobClient("repro");

// upload
await blobClient.UploadAsync(new BinaryData("TEST"), true);