Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Cdn review comments that need service team confirmation

See original GitHub issue

Why is this provisioningState a string instead of enum? We saw that some of the provisioningState definitions are enum but others are string, so I’m wondering if we can unify the type.
Is this validationData a BinaryData?
Some models seem to have the similar even same definitions. One example is operator, you can see ClientPortOperator, CookiesOperator, HostNameOperator and other operators almost share the same definition. The question here is why we have to repeat the definition multiple times. Is it possible to define a common extensible enum in this scenario?
Can we change the type of unit to extensible enum so it can keep consistency with UsageUnit in afdx?
Is the groupId in SharedPrivateLinkResourceProperties a ResourceIdentifier like /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}? Same question in keyId.
Why is this called AfdMinimumTlsVersion instead of AfdTlsVersion? What’s the meaning of Minimum? Same question in cdn MinimumTlsVersion.
Why all these operations have the same description?

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/afdx.json#L90 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/afdx.json#L929 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/afdx.json#L1353 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/afdx.json#L2308

Issue Analytics

State:
Created a year ago
Comments:9 (5 by maintainers)

Top GitHub Comments

1reaction

ChenglongLiucommented, May 16, 2022

Question 1 and 4 have been fixed

1reaction

ChenglongLiucommented, May 12, 2022

@Yao725 Question 7 has been fixed

Top Results From Across the Web

Customer Service Performance Review Phrases and How ...

Contact center performance reviews are an opportunity to anaylize goals, objectives and results. Get customer service performance evaluations in our post.

45 Examples of Effective Performance Evaluation Phrases

A performance review is a documented evaluation of how effectively a team member is meeting their goals and responsibilities. Receiving clear, ...

SAMPLE PERFORMANCE COMMENTS

If there have been counseling sessions, letters of commendation or reprimand, or unofficial performance reviews within the rating period, the supervisor should ......

EMPLOYEE PERFORMANCE REVIEW

WORK RESULTS Measures employee's results in meeting established objectives/expectations/standards of quality, quantity, customer service, and timeliness both.

Performance Management: Giving and Receiving Feedback

Demonstrates care and involvement. • Makes an employee feel acknowledged. When Positive Feedback is appropriate. • When used to recognize specific job ...