[Core] Move Mocking Transport to Azure.Core

API Change Needed

Yes

Background and motivation

Currently Azure.Core request, response, and transport are all very abstract. Implementing a simple “mocking” or a custom transport (e.g. a transport that injects faults) requires a lot of boilerplate code. It would be great to have some simple subtypes of Request, Response, and possibly the transport in Azure.Core.

We have such types in our testing framework, but they need to be cleaned up and the transport needs to be decoupled from recording framework.

API / Feature Proposal

namespace Azure.Core.Pipeline
{
    public class CoreResponse : Response
    {
    }
    public class CoreRequest : Request
    {
    }
}

Time Constraints and Dependencies

No deadline

Stakeholders

@annelo-msft

[christothes]

Wouldn’t users of the SDK just mock the client directly rather than getting involved with the implementation details of the transport?

[JoshLove-msft]

Mocking responses is discussed here - https://devblogs.microsoft.com/azure-sdk/unit-testing-and-mocking/#response. This can be done already using Moq.