TokenCloudCredentials no longer valid - what to use?

Team - recently updated to the latest modules, and was disappointed to find that apparently the Credentials that used to work mostly universally now don’t. I’m working with the KeyVault data plane modules, and used to pass a TokenCloudCredentials instance to KeyVaultClient. However, now I’m getting the following error:

Error: credentials must be one of: ApplicationTokenCredentials, UserTokenCredentials, DeviceTokenCredentials, MSITokenCredentials

This is fine, but none of the docs I can find reflect this change, or how to deal with it (Note that TokenCloudCredentials still works with the ARM management plane).

So a few issues:

• If this changed, can the docs reflect it?
• What is the correct pattern now for using KeyVaultClient, and is it uniform across the SDK modules?
• Lots of references to ms-rest / ms-rest-azure, but I can’t find doc’s on these either…resorting to looking through source. Are there missing doc’s somewhere?

[williexu]

Its a result of this code: https://github.com/Azure/azure-sdk-for-node/blob/master/runtime/ms-rest-azure/lib/credentials/keyVaultCredentials.js#L35-L64

For some context, keyvault used to require users to define their own authentification callback. The change was done to abstract that away from developers and allow them to simply use the returned credentials from a login. Unfortunately, we only took care of the four types of credentials listed in the error.

I’m not familiar with the TokenCloudCredentials type but a solution could be to expand the list of accepted creds. Docs still only retain the old flow: https://github.com/Azure/azure-sdk-for-node/blob/master/lib/services/keyVault/README.md#authentication

Here’s a sample utilizing the newer method: https://github.com/Azure-Samples/key-vault-node-deploy-certificates-to-vm/blob/master/index.js#L61-L67

[mjyeaney]

Agreed - very helpful. That said, what we need to get front and center are the concepts / patterns used throughout the SDK (as you pointed out). No small feat for sure, but that’s the secret sauce to a great dev experience.

Appreciate the insights!