ModuleNotFoundError: No module named 'adal'

• Package Name: azure-common
• Package Version: 1.1.25
• Operating System: Ubuntu 16.04.6 LTS
• Python Version: 3.7

Describe the bug Attempting to use get_client_from_auth_file function from azure-common client_factory module leads to import error.

To Reproduce Steps to reproduce the behavior:

1. pip install azure-common
2. Import: from azure.common.client_factory import get_client_from_auth_file
3. Error: ModuleNotFoundError: No module named ‘adal’

Expected behavior The adal package should be required when installing azure-common as it is imported and used in the code. Thus preventing a module not found error when using get_client_from_auth_file.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context

from azure.common.client_factory import get_client_from_auth_file

../../../virtualenv/python3.7.1/lib/python3.7/site-packages/azure/common/client_factory.py:17: in <module>

    import adal

E   ModuleNotFoundError: No module named 'adal'

[smarlowucf]

Hi, @lmazuel thanks for the explanation. IMHO it’s not nice to force downstream packages to have dependencies on packages that really are used upstream. This can become very troublesome to properly manage. The downstream packages now have to add all this in their own requirements.txt:

azure-common
adal
msrestazure

Which is quite confusing and inaccurate because adal and msrestazure are not used in those packages directly.

[smarlowucf]

Hi @lmazuel can you please point me to documentation describing how to use the new authentication route? I’m very confused and have no luck finding any examples or docs. It would be helpful to see an entire workflow including authentication of a client. For example the code that worked before:

from azure.common.client_factory import get_client_from_auth_file
from azure.mgmt.compute import ComputeManagementClient


compute_client = get_client_from_auth_file(
    ComputeManagementClient,
    auth_path={auth_file...}
)
async_create_image = compute_client.images.create_or_update(...)

If get_client_from_auth_file is legacy then what is replacing this and what’s the new workflow?