Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Handle expanding of new properties on OpenConnectionMessage

See original GitHub issue

We should be able to add new properties to OpenConnectionMessage without breaking older clients. As an example we may want to forward the remote IP address of the client to the application. We should handle this in the ServiceProtocol by skipping over things we don’t understand in the array. This allows us to add things in the future while not breaking older clients (they just don’t skip over the fields they don’t understand)

PS: They may be other types as well but this one is the main one thatomes to mind because it basically sets up all of the connection state (like round tripping claims).

/cc @ccic @xscript

Issue Analytics

State:
Created 5 years ago
Comments:11 (9 by maintainers)

Top GitHub Comments

1reaction

xscriptcommented, May 2, 2018

@anurse I just talked with @davidfowl . He pretty much said the same thing as you did. Right now our service protocol behaves as HubMessagePackProtocol. We will add test cases to cover it.

We just added Handshake between Service and SDK. Right now an error will be returned if version number doesn’t match.

0reactions

xscriptcommented, May 4, 2018

Definitely! They are coming. 😉