Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Issue when generating a url using sas token. Method file_service.make_file_url()

See original GitHub issue

Which service(blob, file, queue) does this issue concern?

File share

Which version of the SDK was used? Please provide the output of `pip freeze`.

azure-storage-file==2.0.1 azure-storage-common==2.0.0 sdk-version

What problem was encountered?

https://github.com/Azure/azure-storage-python/blob/b8c5c9a1bc73065fd015c0fec75617cef263c6ee/azure-storage-file/azure/storage/file/fileservice.py#L233

When genrating a url using the method make_file_url passing a sas token, the generated url has two query strings (‘?’) instead of one. generated_url

The SaS Token generated on Azure portal starts with a query string. SaSToken-Azure

Have you found a mitigation/solution?

Yes. Remove the query string (‘?’) at line 233.

Note: for table service, please post the issue here instead: https://github.com/Azure/azure-cosmosdb-python.

Issue Analytics

State:
Created 4 years ago
Comments:8 (6 by maintainers)

Top GitHub Comments

1reaction

xiafu-msftcommented, Jun 19, 2019

Hi @GeisaFaustino Thanks for catching this bug. You are totally right that ideally the method make_file_url should work with both SAS token and the SAS token generated the API. This pull request https://github.com/Azure/azure-storage-python/pull/611 is to fix that.

1reaction

zezha-msftcommented, Jun 18, 2019

@xiafu-msft we should make a fix, where we check whether the sas token starts with a ‘?’; if not, add a ‘?’.