StorageClient shouldn't log request\response by default

Which service(blob, file, queue) does this issue concern?

Common code

Which version of the SDK was used? Please provide the output of pip freeze.

Latest

What problem was encountered?

storageclient logs request\response data, including secrets, with INFO logger setting. There are 2 problems with this:

1. Possible secrets leak
2. Unnecessary items in the logs, distracts users from the important part of the logs.

This information is not logged with INFO level with other Azure Python SDKs

Have you found a mitigation/solution?

Note: for table service, please post the issue here instead: https://github.com/Azure/azure-cosmosdb-python.

[logachev]

Hi @zezha-msft,

I think by “default” I meant configure the root logger at INFO… Sorry for weird phrasing from my side.

I would follow Python recommendations.

Level	When it’s used
DEBUG	Detailed information, typically of interest only when diagnosing problems.
INFO	Confirmation that things are working as expected.

To me, REST call data is definitely detailed information… INFO is suitable for long-running calls, just to confirm that it’s expected for this call to take a long time to avoid user impression that script is hanged.

Second reason is it would be great to follow the same approach for all Azure Pythin SDKs and it looks like https://github.com/azure/azure-sdk-for-python/ don’t use INFO log information at all (except some packaging scripts).

To your point with REST logs and “Strings to sign”… One option is to use separate loggers (like azure.storage.restapi) for these events, that way if user needs just REST calls, he can enable it explicitly.

I really appreciate detailed explanation from your side!

Thank you for the clarification with Authorization! I didn’t dig into the code to figure out where it comes from, but seeing Shared key next to base64 string definitely looks suspicious 😃

[xaxxon]

This is CLEARLY the wrong behavior. Nothing else from azure spams my logs like this. No one cares if this is consistent “storage api” behavior, it’s not consistent azure client behavior. No one outside microsoft cares about your internal organizations.

Turn off all logging by default, just like all the other azure APIs do. Then let people enable it if they want to see it.