Releases 1.1.7 and 1.1.8 are not backwards compatible with 1.1.6

Based on the changes introduced in v1.1.7, my release to Azure job is getting the following error:

##[Initialize]
##[ValidateParameter]
Error: Execution Exception (state: ValidateParameter) (step: Invocation)
Error:   Cannot read property 'indexOf' of undefined
Error:     TypeError: Cannot read property 'indexOf' of undefined
    at ParameterValidator.validateScmCredentialsSlotName (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:158:42)
    at ParameterValidator.<anonymous> (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:56:18)
    at Generator.next (<anonymous>)
    at fulfilled (D:\a\_actions\Azure\functions-action\v1.1.7\lib\handlers\parameterValidator.js:24:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: Deployment Failed!

My job is running on windows-latest and is currently working now that I’ve specifically pinned v1.1.6 as the version of this action to run. My job is using a publish profile as the Deployment Credential, the publish profile was generated in July and has the following format (the names and passwords have been changed):

<publishData>
  <publishProfile profileName="my-api - Web Deploy" publishMethod="MSDeploy" publishUrl="my-api.scm.azurewebsites.net:443" msdeploySite="my-api" userName="$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api\$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
  <publishProfile profileName="my-api - ReadOnly - FTP" publishMethod="FTP" publishUrl="ftp://waws-prod-blu-095dr.ftp.azurewebsites.windows.net/site/wwwroot" ftpPassiveMode="True" userName="my-api\$my-api" userPWD="***" destinationAppUrl="http://my-api.azurewebsites.net" SQLServerDBConnectionString="" mySQLDBConnectionString="" hostingProviderForumLink="" controlPanelLink="http://windows.azure.com" webSystem="WebSites">
    <databases/>
  </publishProfile>
</publishData>

[Hazhzeng]

Sorry for the late reply and thanks @dastev-ms for the investigation.

Hi @rue-kcarlton This issue should be fixed now https://github.com/Azure/functions-action/blob/v1.3.1/src/handlers/parameterValidator.ts#L172-L173.

[rue-kcarlton]

@Hazhzeng here’s my workflow snippet as it existed during the first of the failed runs:

   - name: Run Azure functions action to deploy ${{ steps.vars.outputs.RELEASE_NAME }} to ${{ env.FLEET }}
      uses: Azure/functions-action@v1
      id: fa
      with:
        app-name: ${{ env.AZURE_FUNCTIONAPP_NAME }}
        package: ${{ env.AZURE_FUNCTIONAPP_PACKAGE_PATH }}
        publish-profile: ${{ secrets.AZURE_FUNCTIONAPP_PUBLISH_PROFILE }}
        slot-name: staging

I think I may have figured out the issue… based on older documentation, I still have the SCM_CREDENTIALS secret set which includes the Azure Publish Profile, but not the AZURE_FUNCTIONAPP_PUBLISH_PROFILE secret. I haven’t been able to test my theory as I didn’t want to release again over the holiday weekend (or on cyber Monday).