Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add support for TrafficSplit annotations

See original GitHub issue

When SMI traffic handling is selected, the TrafficSplit that gets generated (both for blue/green and canary is pretty hard-coded with only weights and service names.

At least with Istio, this will only work for services accessed from within the cluster. To get this working with ingress traffic, the Istio VirtualService needs to have a gateway attached.

The Istio SMI adapter has support for setting this through annotations but there’s no way to add annotations to the generated TrafficSplit.

It would be cool to be able to add annotations to the TrafficSplit to support cases like this. It could be a key/value list parameter to the task and just copied into the TrafficSplit when it’s generated. If none are present, you get the same thing you get now. (Admittedly, I’m kind of new to GitHub Actions and I’m unclear if it’d need to be a multiline string or if you can have object style parameters like Azure DevOps. Either way is fine.)

Corresponding issue filed for Azure DevOps KubernetesManifest task.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:13

github_iconTop GitHub Comments

tilligcommented, Mar 9, 2022

Awesome. We’re still in the process of getting our GitHub Enterprise system underway. That’ll be my test bed for verifying my changes before submitting the PR since I don’t really have any other system with everything wired up. However, I do plan on getting a PR in here so I’ll keep this open while I work on it. Thanks!

OliverMKingcommented, Aug 17, 2022

This feature was added to the latest version 😃. You can use the traffic-split-annotations input. Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Set Up Kubernetes Traffic Splitting with Istio - Docs
To add the Traffic Split step, in your Workflow, click Add Step. Select Traffic Split. The Traffic Split settings appear. Step 7: Define ......
Read more >
Deployments using Traffic Splitting | NGINX Service Mesh
This topic provides a guide for using traffic splits with different deployment strategies. ... Set up a Kubernetes cluster with NGINX Service Mesh...
Read more >
How to Do Traffic Splitting in Kubernetes - YouTube
When it's time to move from an old service to the new version, you don't want to move all your traffic at once...
Read more >
Splitting Traffic | App Engine standard environment for Python 2
Select one or more versions to which you want to split traffic. · Click Split traffic and then specify: The method that you...
Read more >
Traffic management | OpenShift Container Platform 4.9
You can add tags to revisions and then split traffic according to the tags you have set. Custom URLs for revisions. Assigning a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found