Parsing of image substitution incompleteSee original GitHub issue
This is related to #23 in the sense that the symptom is that replacements don’t work.
The regex used to parse an image identifier in the yaml is
const imageKeyword = line.match(/^ *image:/);.
I had an issue where it was not working for me, because I had a config like this:
.. containers: - image: test name: test
Which isn’t correctly parsed by the regex.
The clean solution would be to use a real yaml parser, but an ugly quick fix could be to allow for this case.
If you want to have the quick fix I can make a PR, just let me know.
The correct regex is:
/^ *(?:- )?image:/
- Created 3 years ago
- Comments:7 (4 by maintainers)