question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Parsing of image substitution incomplete

See original GitHub issue

This is related to #23 in the sense that the symptom is that replacements don’t work.

The regex used to parse an image identifier in the yaml is const imageKeyword = line.match(/^ *image:/);. I had an issue where it was not working for me, because I had a config like this:

..
  containers:
    - image: test
      name: test

Which isn’t correctly parsed by the regex.

The clean solution would be to use a real yaml parser, but an ugly quick fix could be to allow for this case.

If you want to have the quick fix I can make a PR, just let me know. The correct regex is: /^ *(?:- )?image:/

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
thesattirajucommented, Dec 21, 2020

Cool. Tag @shigupt202 in your PR so he can take it forward. 😃

1reaction
thesattirajucommented, Dec 21, 2020

That’s a good catch. @SamMousa would you be willing to raise a fix for the same?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Learning to Parse Images - Computer Science
The parse trees describe the segmentations of the image at every level of granularity, from individual pixels to the whole image.
Read more >
Non-parametric scene parsing: Label transfer methods and ...
Scene parsing is the problem of densely labeling every pixel in an image with a meaningful class label. Driven by powerful methods, remarkable...
Read more >
populate image array with parse in swift - xcode - Stack Overflow
Hi I'm new with swift and parse.com, I'm trying do populate my array with already saved images in parse, try to use the...
Read more >
Error while generating variables data set "Could not parse ...
... cards the errors occur "could not parse the file contents as a d. ... incomplete " and "Could not export dataset because...
Read more >
Responsive images - web.dev
A picture is worth 1000 words, and images play an integral part of every ... JavaScript image replacement checks the capabilities of the ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found