Support different manifest delimiters
See original GitHub issueI’m working in an environment where I went to set the manifests dynamically. Specifically I have an environment variable that contains the list of manifests, but passing this into the action does not work:
- name: Set manifests
run: |
echo 'MANIFESTS<<EOF' >> $GITHUB_ENV
find k8s/shared k8s/staging -type f >> $GITHUB_ENV
echo 'EOF' >> $GITHUB_ENV
- run: echo "$MANIFESTS"
- name: Authenticate to kubernetes
uses: azure/k8s-set-context@v1
with:
method: service-account
k8s-url: ${{ secrets.KUBERNETES_URL }}
k8s-secret: ${{ secrets.STAGING_K8S_SECRET }}
- uses: Azure/k8s-deploy@v1.4
with:
namespace: 'staging'
manifests: |
${{ env.MANIFESTS }}
images: |
ghcr.io/herams-who/herams-backend/app:${{ github.sha }}
kubectl-version: 'latest'
There is no valid syntax that’ll work here (afaik) because Github Actions will not properly put in multiline values here. This could be easily solved if a different separator would be accepted.
Interestingly, current code splits by \n
.
https://github.com/Azure/k8s-deploy/blob/main/src/run.ts#L62
let manifests = manifestsInput.split('\n');
A clean solution would be to make the separator configurable as an input in the action. I can make a PR.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:9 (3 by maintainers)
Top Results From Across the Web
Supported formats for Amazon S3 manifest files
Valid formats are CSV , TSV , CLF , ELF , and JSON . The default value is CSV . delimiter – (Optional)...
Read more >Manifest Format
Allows different portions of archives to be signed by different parties, as well as overlap, and unsigned files. Supports needs for Java archives...
Read more >Common Data Model metadata: Introducing manifest
The manifest object describes the list of entities in the solution, giving a detailed schema description for each entity, a collection of data ......
Read more >Specify multiple delimiters for Redshift copy command
This will let you load your data to Redshift and then query in database to see where your columns start being out of...
Read more >Can we generate the BIX manifest files with pipe(|) delimiter ...
Hi All, Can we generate the BIX manifest files as csv files with pipe(|) as delimiter.By default pega is generating the CSV files...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Thanks for the quick release @Ganeshrockz. Tested right now and it’s working like a charm!
I have raised a PR to support both commas and new line as delimiters. @SamMousa and @uzi0espil, I believe this should address your use case