Feedback Requested: Synchronous Methods
See original GitHub issueHi Folks,
Looking for feedback on the introduction of synchronous methods. We’ve received feedback from many of you that synchronous methods are simpler to integrate with and use. To that end we are considering providing synchronous interfaces (interfaces that do no leverage callbacks) to return results to you. Since many of operations involve network operations or cross process calls (invoking the authentication broker via bound service and/or Account Manager). We will annotate these operations with @WorkerThread
annotation. In addition if we detect that they are being invoked from the UI thread we will immediately throw an IllegalStateException.
These methods will be blocking calls…
I’d prefer not to add “Sync” to the end of method names, but if you have a suggestion on naming and or related to additional annotations please pass it along.
thanks
shane
Issue Analytics
- State:
- Created 4 years ago
- Reactions:3
- Comments:5 (3 by maintainers)
Top GitHub Comments
I think I like that the best in terms of not colliding with other existing async/blocking semantics. Thanks @joshfriend
Introduced in MSAL v1.0.0