Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Leak of Activity by ApiDispatcher

See original GitHub issue

When running with LeakCanary, it’s detecting a leak

* GC ROOT static com.microsoft.identity.client.internal.controllers.MSALApiDispatcher.sCommand
* references com.microsoft.identity.client.internal.controllers.MSALInteractiveTokenCommand.mParameters
* references com.microsoft.identity.client.internal.controllers.MSALAcquireTokenOperationParameters.mActivity

A potential fix would be to clear out sCommand after completeInteractive is called

public static void completeInteractive(int requestCode, int resultCode, final Intent data) {
        sCommand.notify(requestCode, resultCode, data);
+       sCommand = null;
}

Issue Analytics

State:
Created 5 years ago
Reactions:4
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

iambmeltcommented, Aug 7, 2019

PR with proposed fix open here: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/580

0reactions

iambmeltcommented, Aug 7, 2019

Merged. This will ship in an upcoming release.

Top Results From Across the Web

Why LeakCanary reports about leak of each activity's field ...

Why LeakCanary reports about leak of each activity's field even right after activity was just started? Ask Question. Asked 5 years, 11 months ......

Potential library leak in Android SDK's transition #2087 - GitHub

ActivityThread class │ Leaking: NO (OnboardingActivity↓ is not leaking ... NO (SplashFragment↓ is not leaking and Activity#mDestroyed is ...

How to get rid of memory leaks? A practical approach using ...

1 . Detecting retained objects. LeakCanary hooks into the Android lifecycle and detects when activities and fragments are destroyed and should be garbage ......

Code recipes - LeakCanary

Watching objects with a lifecycle¶. The default configuration of LeakCanary will automatically watch Activity, Fragment, Fragment View and ViewModel instances.

Simple Index

a-pandas-ex-adb-execute-activities · a-pandas-ex-adb-settings-to-df · a-pandas-ex-adb-to-df ... api-dispatcher · api-display-purposes ... auto-py-torrent