AcquireToken should return IAuthenticationResult instead of AuthenticationResult

IPublicClientApplication.AcquireTokenAsync & IPublicClientApplication.AcquireTokenSilentAsync currently return an AuthenticationResult which is restrictive with internal ctor’s, and ultimately requires an instance of an internal class to provide a token.

This creates a problem for unit testing other libraries. While IPublicClientApplication can be mocked, there is no easy way to return a result as part of a unit test in external libraries. If AcquireTokenAsync and AcquireTokenSilentAsync were to return an IAuthenticationResult instead this would make it easy to create a mock response for unit testing other libraries.

[jmprieur]

Thanks for your tip, @AmirSasson For info on the migration, in case this helps, you can checkout https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-net-migration

[jmprieur]

@AmirSasson ADAL is deprecated. We won’t change it.