question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update Documentation for Android

See original GitHub issue

Documentation Related To Component:

Currently the docs for Android specify that you must add the following to your AndroidManifest

<activity android:name="microsoft.identity.client.BrowserTabActivity">
	<intent-filter>
		<action android:name="android.intent.action.VIEW" />
		<category android:name="android.intent.category.DEFAULT" />
		<category android:name="android.intent.category.BROWSABLE" />
		<data android:scheme="msal{client_id}" android:host="auth" />
         </intent-filter>
</activity>

This should be updated to suggest that you may consider doing something in code such as:

[IntentFilter(new[] { Intent.ActionView }, 
    Categories = new[] { Intent.CategoryBrowsable, Intent.CategoryDefault },
    DataHost = "auth",
    DataScheme = Constants.DataScheme)] // where the constant is msal{client_id}
public class MSALActivity : BrowserTabActivity
{
        
}

Please check those that apply

  • typo
  • documentation doesn’t exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

It’s really a lot easier for developers to swap out Constants files than write scripts to do regex replacements in app Manifests. Similarly it should be investigated if there is a way we can achieve something similar from code for iOS.

Documentation & Samples should be helping to guide people towards best practices and not bad practices.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
tipacommented, Dec 20, 2020

@jmprieur just found this issue as I was confused by the docs when going through them. In the XML example, it says to write different values than in the code example - so what is the correct way of doing it now? image image

1reaction
jennyf19commented, Dec 9, 2019
Read more comments on GitHub >

github_iconTop Results From Across the Web

Documentation | Android Developers
Learn to build small apps, add new feature to existing apps, and learn to use the latest tools. Online video courses. Learn Android...
Read more >
Update the IDE and SDK tools | Android Studio
To manually check for updates, click File >Settings >Appearance & Behavior > System Settings > Updates (on macOS, Android Studio > Check for ......
Read more >
Update digital document
Update digital document ... Edit an existing note or document. Determine the document to edit by title or content using the digitalDocument.
Read more >
Update software application | Documentation
Determine the setting to be updated by name using the softwareApplication.softwareSetting.name intent parameter. Then, update the value of the ...
Read more >
Features and APIs Overview
Android 12 introduces great new features and APIs for developers. The sections below help you learn about features for your apps and get...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found