Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

MsalGuard to support redirect on failure

See original GitHub issue

I’m submitting a…


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

Chrome version 74.0.3729.131
Firefox version XX
IE version XX
Edge version XX
Safari version XX

Library version

@azure/msal-angular Library version: 0.1.2

Expected behavior

It would be neat if the MsalGuard would support redirecting to an access denied page. The CanActivate interface supports returning a UrlTree. I believe this was added in Angular v7.1.

So if we can have MsalConfig.failureRedirectUri = "access-denied-page" that would be a lot simpler then having to subscribe to the failure event.

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:10 (7 by maintainers)

Top GitHub Comments

3reactions

DarylThayilcommented, May 10, 2019

@snebjorn Thank you for sharing your thoughts. We are currently finishing up work on our msal-core library, and will begin work on msal-angular this summer. We will consider your suggestion, and investigate the impact on the library.

cc @negoe

2reactions

jasonnuttercommented, Apr 30, 2020

@snebjorn A PR would great, thanks!