AddSignIn should be more robust to authority having or not a trailing slash.
See original GitHub issueWebApiAuthenticationBuilderExtensions.EnsureAuthorityIsV2_0
was extracted from the WebApiAuthenticationBuilderExtensions.AddProtectedWebAPi
method so that we can unit test it. I think it should stay there as this method takes a JwtBearerOptions
parameter and It’s unit tested.
It provides a more robust processing of authorities accepting them to end in / or not.
We want to do somthing similar for WebAppAuthenticationBuilderExtensions.AddSignIn( this AuthenticationBuilder builder, Action<OpenIdConnectOptions> configureOpenIdConnectOptions, Action<MicrosoftIdentityOptions> configureMicrosoftIdentityOptions, string openIdConnectScheme = OpenIdConnectDefaults.AuthenticationScheme, string cookieScheme = CookieAuthenticationDefaults.AuthenticationScheme, bool subscribeToOpenIdConnectMiddlewareDiagnosticsEvents = false)
, but with a method enabling an OpenIdConnectOptions
.
Issue Analytics
- State:
- Created 4 years ago
- Comments:8
Top GitHub Comments
I figured out the issue in the end. It was a typo in the AppSettings.JSON.
Switching to a local version of the project made the error much more obvious, once I’ve got things up and running correctly I’ll have another go at using the nuget package instead. Thanks for the quick reply though.
included in 0.1.1-preview release