question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

AddSignIn should be more robust to authority having or not a trailing slash.

See original GitHub issue

WebApiAuthenticationBuilderExtensions.EnsureAuthorityIsV2_0 was extracted from the WebApiAuthenticationBuilderExtensions.AddProtectedWebAPi method so that we can unit test it. I think it should stay there as this method takes a JwtBearerOptions parameter and It’s unit tested.

It provides a more robust processing of authorities accepting them to end in / or not.

We want to do somthing similar for WebAppAuthenticationBuilderExtensions.AddSignIn( this AuthenticationBuilder builder, Action<OpenIdConnectOptions> configureOpenIdConnectOptions, Action<MicrosoftIdentityOptions> configureMicrosoftIdentityOptions, string openIdConnectScheme = OpenIdConnectDefaults.AuthenticationScheme, string cookieScheme = CookieAuthenticationDefaults.AuthenticationScheme, bool subscribeToOpenIdConnectMiddlewareDiagnosticsEvents = false), but with a method enabling an OpenIdConnectOptions.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8

github_iconTop GitHub Comments

1reaction
wowfoodcommented, Apr 28, 2020

I figured out the issue in the end. It was a typo in the AppSettings.JSON.

Switching to a local version of the project made the error much more obvious, once I’ve got things up and running correctly I’ll have another go at using the nuget package instead. Thanks for the quick reply though.

1reaction
jennyf19commented, Apr 22, 2020
Read more comments on GitHub >

github_iconTop Results From Across the Web

RESTful URI trailing slash or no trailing slash
The two positions are: The trailing slash indicates a resource and not having does not. The other argument is that the trailing slash...
Read more >
Tutorial: Sign in users in a Node.js & Express web app
For the main (or global) Azure cloud, enter https://login.microsoftonline.com/ (include the trailing forward-slash). For national clouds (for ...
Read more >
Is it good practice to require a trailing forward slash in ...
Requiring that the directory must not have a trailing slash would be extremely annoying for interactive use on the console: auto-completion ...
Read more >
To slash or not to slash | Google Search Central Blog
Historically, it's common for URLs with a trailing slash to indicate a directory, and those without a trailing slash to denote a file:....
Read more >
Should I switch from trailing slash to no trailing slash?
I have a website which has had trailing slashes added to the URLs by 301 redirects for over 3 years. However, the custom...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found