Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
[Feature Request] Simplify AuthenticationBuilder.AddSignIn extension method for web app
See original GitHub issueIs your feature request related to a problem? Please describe.
On the AddSignIn method signature https://github.com/AzureAD/microsoft-identity-web/blob/7d33e9f4351ac679382cd3c0f1bc61140376e34f/src/Microsoft.Identity.Web/WebAppAuthenticationBuilderExtensions.cs#L60-L66 is it necessary to have both the configureOpenIdConnectOptions and configureMicrosoftIdentityOptions parameters?
Given that MicrosoftIdentityOptions inherits from OpenIdConnectOptions I find this confusing as it is not clear which takes precedence or even if the inherited options must be set in the configureOpenIdConnectOptions delegate or if setting everything in the configureMicrosoftIdentityOptions delegate is fine.
Describe the solution you’d like
Remove the configureOpenIdConnectOptions parameter so there is a single point of configuration.
Issue Analytics
- State:
- Created 3 years ago
- Comments:5
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I wonder if we could not use an approach such as this one: https://github.com/dotnet/aspnetcore/blob/master/src/Azure/AzureAD/Authentication.AzureAD.UI/src/AzureADOpenIdConnectOptionsConfiguration.cs where the OpenIdConnectOptions were computed from the AzureADOptions in AzureAD.UI
cc: @jennyf19 @pmaytak @henrik-me
Included in 0.2.0-preview release