No lint failure when fragment variable is not defined

Describe the bug

• Given two .graphql files, one with a query operation and another with a fragment
• And fragment uses a variable
• And query does not define input variable

Then: there is no lint failure

(inverse of #651 )

To Reproduce Steps to reproduce the behavior:

git clone -b fragment-with-variable [e-mail]:beaucollins/graphql-lint-fragment-variables.git
npm install
npm run lint

Expected behavior

The same error as if the fragment was embedded within the query:

./graphql-lint-fragment-variables/src/GetWidgets.graphql
  9:36  error  Variable "$usageInterval" is not defined by operation "AllWidgets"  @graphql-eslint/no-undefined-variables

Environment:

• OS: macOS 11.5.2
• @graphql-eslint/eslint-plugin@2.2.0:
• NodeJS: v16.9.1

[dotansimha]

Fixed in ``@graphql-eslint/eslint-plugin@2.3.0`

[beaucollins]

I don’t get errors from eslint, can you verify your branch?

Correct, not having an eslint error here is the problem. It’s a false negative.

It doesn’t produce a lint error but it should. The fragment requires a variable but the linter doesn’t understand that when the fragment is defined elsewhere.

As an example copy the contents of the fragment in place within the query operation and it will show an error.