Significantly increased memory usage in 3.13.0
See original GitHub issueIssue workflow progress
Progress of the issue based on the Contributor Workflow
- 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox
Please make sure the graphql-eslint version under
package.json
matches yours. - 2. A failing test has been provided
- 3. A local solution has been provided
- 4. A pull request is pending review
Describe the bug
3.13.0 has increased memory consumption over 3.12.0, to the point that in CI the process is OOM-killed when run against the GitLab repository.
Using 3.12.0, the job passes reliably, while on 3.13.0 it fails reliably.
To Reproduce Steps to reproduce the behavior:
(Apologies that this isn’t a minimal reproduction. If/when I have time, I’ll make one and post it here.)
For now:
- See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/102654.
- The commit fb10562ab186e39800f5006601bce362e0d0474b bumps to 3.13.0, and fails to run in CI.
- The commit 46548bfb0e624c4eb5fc3f8120373f8ae11dab7d moves back down to 3.12.0, and runs successfully (as does latest master)
Expected behavior
Memory usage shouldn’t be significantly higher than with 3.12.0.
Environment:
- OS: Linux (Docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bullseye-ruby-2.7.patched-golang-1.18-node-16.14-postgresql-12:rubygems-3.2-git-2.36-lfs-2.9-chrome-103-yarn-1.22-graphicsmagick-1.3.36), though probably any Linux would do.
@graphql-eslint/eslint-plugin
: 3.13.0- Node.js: 16.14.0
Additional context
I suspect that https://github.com/B2o5T/graphql-eslint/pull/1222 might be implicated, since it touches some caching-related stuff and was the most significant change between 3.12.0 and 3.13.0. But that’s just a hunch.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:7 (3 by maintainers)
Top GitHub Comments
Sadly it still OOMs. It’s frustrating that I can’t replicate this locally 😩
I think I might just set
NODE_OPTIONS=--max-old-space-size=3584
for now instead, or at least try different values.Huh, even with
NODE_OPTIONS=--max-old-space-size=3584
it got killed 🤔I’m going to have to put this aside for now and stay on 3.12.0 until I have more time to look into this.