Unexpected results for strings and doubles in expression parsing with generic lexer

Hello,

I am getting unexpected results when using this configuration:

enum TestTokens
{
    [String("'", "'")] STRING,
    [Double] DOUBLE,
    [Keyword("eq")] EQ,
}

class TestParser
{
    public static Parser<TestTokens, Expression> GetParser()
    {
        var builder = new ParserBuilder<TestTokens, Expression>();
        var result = builder.BuildParser(new TestParser(), ParserType.EBNF_LL_RECURSIVE_DESCENT, nameof(TestParser) + "_expressions");
        return result.Result;
    }

    [Operand]
    [Production("operand: STRING")]
    public Expression LiteralString(Token<TestTokens> value)
        => Expression.Constant(value.StringWithoutQuotes);

    [Operand]
    [Production("operand: DOUBLE")]
    public Expression LiteralDouble(Token<TestTokens> value)
        => Expression.Constant(value.DoubleValue);

    [Operation((int)TestTokens.EQ, Affix.InFix, Associativity.Left, 1)]
    public Expression BinaryOperator(Expression left, Token<TestTokens> operation, Expression right)
        => Expression.Equal(left, right);
}

The test and results:

var parser = TestParser.GetParser();
var result1 = parser.Parse("123.456");
// result1.Result is a ConstantExpression with Value=123456D
// -> the decimal separator was ignored?

var result2 = parser.Parse("'str1' eq 'str2'");
// result2.Result is a ConstantExpression with Value="str1'eq 'tr2"
// -> it should have been a BinaryExpression with ConstantExpression arguments with values "str1" and "str2"

Thank you

[LaXiS96]

Thank you very much for both fixes, I can confirm it’s now working as expected!

[LaXiS96]

The sample code is only using LINQ expressions so a using System.Linq.Expressions; should be sufficient; I don’t have other custom classes.