dead-code-elimination erroneously tries to inline expressions into JSXIdentifiers.

Reproduction on RunKit: https://runkit.com/tolmasky/dead-code-inlines-jsxidentifiers

function Input(element)
{
    var ElementType = element || "input";

    return <ElementType ref = "input" />;
}

This will try to put (element || "input") into the actual JSX element, (something like <(element||"input") ref = "input/>), which is not allowed, and will thus throw this error:

TypeError: unknown: Property name of JSXOpeningElement expected node to be of a type [“JSXIdentifier”,“JSXMemberExpression”] but instead got “LogicalExpression”

It is important that I run this before my actual React transforms, since there are in-between transforms that rely on the right code having been removed, so I can not use as a temporary workaround switching the order of the transformations.

[hzoo]

I believe this is because @tolmasky actually is using jsx as code instead of for react? yeah hard to say since it does feel wrong to add all these workarounds everywhere (unless we could make that generic too)

[boopathi]

Using isExpression sounds good

Aside: From the JSX Spec

JSXElementName :
  JSXIdentifier
  JSXNamespacedName
  JSXMemberExpression

I could go submit a quick PR to babel-types to get that changed and then make the non-JSX requiring PR here. Does that sound reasonable?

👍 Sure. Thanks.