Incorrect minify-empty-function?

Why is foo(emptyFunction('how long', '?')); minified to foo(false)?

https://github.com/amasad/babel-minify/blob/0a37687f01fefeacace653d7537e132b386b79f3/packages/babel-plugin-minify-empty-function/__tests__/empty-function-test.js#L37

Is this test not final/functional? https://github.com/amasad/babel-minify/blob/0a37687f01fefeacace653d7537e132b386b79f3/packages/babel-plugin-minify-empty-function/__tests__/empty-function-test.js#L12

And where does this emptyFunction come from? It looks like it’s noop inserted by other plugins, but its usage might be confusing for direct users.

[fregante]

I’m still confused about the specificity of this transform. Verifying only the name makes it unsafe

This:

function emptyFunction() {
  return function () {};
}
var fn = emptyFunction();

would still transformed to:

function emptyFunction() {
  return function () {};
}
var fn = undefined;

It should probably test whether the function is actually a noop, or possible evaluate/resolve it properly like CC does

[amasad]

This is a copy from the internal FB transform which I believe does transform it to false if it’s part of larger expression. Agree that it doesn’t make much sense outside of FB. If this can be implemented via the replace plugin then great.