question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

_getPluginForFilename breaks for query strings containing periods

See original GitHub issue

I’m generating a signed url using google cloud storage. I’ve placed an example URL below (Not a working url). The query parameters contain . which is throwing off the plugin selection here.

I have a few thoughts/questions.

  • Is there a reason to have rootUrl and sceneFilename here aside from picking the loader plugin? I found it a little annoying to have to parse my url into those separate parts. I’d prefer to just pass the entire path into the loader.

  • Is there a way to be more explicit about which plugin to use?

Example of problematic url

https://storage.googleapis.com/somebucket/YellowCar.glb?GoogleAccessId=bucket-upload@someproject.iam.gserviceaccount.com

This results in this ?googleaccessid=bucket-upload@someproject.iam.gserviceaccount.com being extracted as the extension.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
deltakoshcommented, Nov 16, 2017

I keep it open because I want to fix this issue:)

0reactions
FreakTheMightycommented, Nov 16, 2017

@deltakosh thanks for pointing that out. That unblocked me. Not sure if you want to keep this open to improve the extension parsing, I’ll leave that up to you.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to send a query string that ends in a period character?
This works fine for most search strings. But if the search string ends in a period ( . ) character, the request breaks...
Read more >
Periods Handling in URL Parameters #25541
We ran into a bug in the handling of periods in an API end point URL. This query wouldn't work due to the...
Read more >
Passing Information via Query Strings
Data can be passed into a survey using a query string. Once passed, the data can be saved as embedded data with the...
Read more >
7.4 - Request Format
The following examples show query strings. Take note that line breaks are used for readability only and should not be present in actual...
Read more >
36663 (Wordpress 4.5 Query Strings Replacing "." with "_")
While i understand that PHP doesn't support a period in a query string value, ... which breaks the JavaScript that is looking for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found