question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TypeScript compile fails with Typescript 3.1

See original GitHub issue
  • Bug repro on playground: N/A
  • Expected result: Typescript project using BabylonJS compiles with TS 3.1
  • Current result: Typescript project using BabylonJS does NOT compile with TS 3.1

TypeScript 3.1 released recently and, during some changes to a project of mine, I updated my dep from 3.0.1 to 3.1.1. Almost immediately, however, builds began to fail.

This message keeps getting written to console:

Using tsc v3.1.1
node_modules/babylonjs/babylon.d.ts(250,5): error TS2687: All declarations of 'fullscreen' must have identical modifiers.
node_modules/babylonjs/babylon.d.ts(293,5): error TS2687: All declarations of 'orientation' must have identical modifiers.
node_modules/babylonjs/babylon.d.ts(293,5): error TS2717: Subsequent property declarations must have the same type.  Property 'orientation' must be of type 'ScreenOrienta
tion', but here has type 'string'.
node_modules/typescript/lib/lib.dom.d.ts(4030,14): error TS2687: All declarations of 'fullscreen' must have identical modifiers.
node_modules/typescript/lib/lib.dom.d.ts(13881,14): error TS2687: All declarations of 'orientation' must have identical modifiers.

I’ve tried this with both 3.3.0-beta.2 and 3.3.0-rc.4 of BabylonJS. This issue does not happen when I roll back to TSC v3.0.

I suspect it has something to do with these breaking changes, just judging by the output, but I don’t know for certain.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:9
  • Comments:23 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
deltakoshcommented, Oct 8, 2018

Should be good now Please let me know if you can test it

0reactions
MackeyK24commented, Apr 26, 2019

FYI… the archive folder is for OLDER versions. The date in the filename is the date i moved it to archive folder… That version is NOT the official 2019 build of toolkit.

The 2019 version compatible builds are at: https://github.com/BabylonJS/UnityExporter/tree/master/Redist

I will update that build as soon i get the FIX from @bghgary about the Bone Matrix for skeletons, plus it has a couple other mesh fixes in it like: Tangents and Vertex Colors for the meshes and a MUCH better ALPHA/TRANSPARENCY Export (Not as good as the new upcoming version… but a stop gap until i get the new version ready)

Read more comments on GitHub >

github_iconTop Results From Across the Web

ERROR in The Angular Compiler requires TypeScript >=3.1.1 ...
To fix this install the specific typescript version 3.1.6 npm i typescript@3.1.6 --save-dev --save-exact.
Read more >
Documentation - TypeScript 3.9
TypeScript 3.9 addresses this issue by changing the internals of how the compiler and language service caches file lookups.
Read more >
Typescript compile fails in build - works locally - CircleCI Discuss
node_modules/@types/uuid/node_modules/@types/node/index.d.ts(2381,15): error TS2300: Duplicate identifier 'URL'.
Read more >
TypeScript Compiling with Visual Studio Code
No, the TypeScript language service that ships with Visual Studio 2019 and 2022 isn't compatible with VS Code. You will need to install...
Read more >
Compile and build TypeScript code using NuGet
Learn how to add TypeScript support to your Visual Studio projects by using the NuGet package.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found