Backstage icons are not replaced by the ones provided in options when creating the app

According to this comment here https://github.com/backstage/backstage/issues/7443#issuecomment-938115930 we should be able to override the app icons. This is not happening.

Expected Behavior

The icons should be overridden

Current Behavior

The icons are not overridden

Steps to Reproduce

Include icons object in the createApp options like this, for example:

import BusinessIcon from '@material-ui/icons/Business';
import VoicemailIcon from '@material-ui/icons/Voicemail';

createApp({
  ...
  icons: {
    business: BusinessIcon,
    email: VoicemailIcon // this one here is not working
  }
  ...
})

The business icon works fine because it is a non-existing one, a new one from the backstage perspective. However, the email icon already exists and the backstage is not picking up the newly assigned icon.

I’ve tried to override a couple of the available keys from here https://github.com/backstage/backstage/blob/f00e7ababefa8abd4095a7c712583898dcbd864c/packages/core-app-api/src/app/icons.tsx#L57 but no luck

Context

I’m trying to customize the app icons, therefore, overriding some of the existing ones should be possible

Your Environment

• NodeJS Version (v14): v14.17.5
• Operating System and Version (e.g. Ubuntu 14.04): Windows 10
• Browser Information: Chrome

[jhaals]

I’m going to close this issue specifically as we’ve figured out that those are currently hardcoded. Feel free to raise a specific issue about replacing the hardcoded icons or we are happy to accept PRs that addresses this.

Thanks!

[ProticM]

Ok, so it seems that we cannot do much until the inner icons are switched/used from that location