Can't pass number from template to custom action step

Expected Behavior

Using the number type for a custom action’s input should work.

Current Behavior

It appears there is no way to pass a number type from a custom template to a custom action step.

The following error occurs:

InputError: Invalid input passed to action uip:argocd-deploy, instance.port is not of a type(s) number

Possible Solution

¯\_(ツ)_/¯

Steps to Reproduce

1. In the template, define a property like so:

port:
  title: Port
  type: integer
  default: 8080

1. Pass that property to an action

- id: custom-action
  name: Custom Action Name
    action: custom:action
    input:
      port: '{{ json parameters.port }}' # I have also tried '{{ parameters.port }}' with and without quotes

1. In the action define the input property with the number type:

{
  id: 'custom:action',
  schema: {
    input: {
      type: 'object',
      properties: {
        port: {
          type: 'number',
          title: 'Port',
          description: 'The port the service runs on.'
        }
      }
    }
  }
}

4. Try to use the template and see the error.

Context

I can workaround this by using the string type and using Number.parseInt() so this isn’t a blocker.

Your Environment

N/A

[mtlewis]

Thanks for reporting @ConnorDY! I think I can see the cause: there are some special cases in the scaffolder which mean it’s possible to work with complex template inputs like lists and arrays. It should be possible to extend this conditional to catch numeric strings too - we should be able to run them through JSON.parse and get the right result.

FWIW this is something we’re looking to improve - this RFC contains some details if you’re interested.

[freben]

Alright, let’s close this for now and presume that it has been fixed in the new template format. Do feel free to reopen if this is not the case!