Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Org Plugin: Themed Ownership Card

See original GitHub issue

Feature Suggestion

Currently the OwnershipCard only uses the default theme colours
It would be nice if they matched the theme of the backstage app in which they the component resides
Potential drawback: custom themes that don’t cover all the page theme ids will all fallback to the default theme and so the page will look less exciting. (Though will still match the page themes within the app)

Possible Implementation

I had a go at making the change so if this is something that people think belongs in the base plugin I’m happy to submit a PR. (Just need to figure out the changeset and tidy some things up). The theme is already threaded through to the styles so it was simply a case of reading the styles from the theme.

Example (monochrome theme):

Would love to know people’s thoughts on this.

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

egnwdcommented, Feb 16, 2021

Happy to open a PR for this, I just didn’t want to conflate the storybook PR with this update. I need to look at seeing if I can get the theme I use for the widget to respond the the light mode/dark mode button in the storybook UI.

0reactions

egnwdcommented, Feb 18, 2021

@freben I had some time to finish that PR hopefully that answers your question/opens the discussion of how to possibly change my implementation 😄