question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Port date library usage over to use luxon

See original GitHub issue

As per adr010-luxon-date-library (discussed in #3401) we should convert existing usages of date libraries (e.g. momentjs, dayjs, etc.) over to use luxon.

Usages of moment.js

  • plugins/auth-backend (#4386)
  • plugins/catalog (#4389)
  • plugins/circleci (#6022)
  • plugins/cloudbuild (#7140)
  • plugins/cost-insights (#6159)
  • plugins/github-actions (#6224)
  • plugins/scaffolder (#4606)

Usages of day.js

  • plugins/circleci (#7190)
  • plugins/cost-insights (#6159)

Usages of date-fns

  • plugins/pagerduty (#4478)

Other

  • plugins/sentry (uses timeago.js) (#6021)

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:9
  • Comments:10 (7 by maintainers)

github_iconTop GitHub Comments

6reactions
adamdmharveycommented, Sep 16, 2021

WOW! An effort across a large number of team members, both core and the community, and we seem to have met the ADR 🎉 🎉 👍🏻

I triple checked, and the only references left in the raw code are a few package-lock elements, which infers they are being imported by being deps of ANOTHER 3rd party package. But the Backstage code itself involves no imports for these packages any longer.

Given this, I’m closing this issue and want to thank everyone who helped make this cleanup and alignment possible. WAY TO GO TEAM!!!

4reactions
HHoggcommented, Sep 15, 2021

PR created for the last plugin ☝️

Read more comments on GitHub >

github_iconTop Results From Across the Web

Luxon – A library for working with dates and times in JS
I'm in need of a fast date and time library (close to realtime) and have ... I haven't done a ton of perf...
Read more >
Date formatting using luxon - Learn web development | MDN
We'll do the actual formatting using luxon, a powerful, modern, and friendly library for parsing, validating, manipulating, formatting and ...
Read more >
ADR010: Use the Luxon Date Library
We will use Luxon as the standard date library within Backstage. Luxon provides a similar feature set and API to Moment.js , but...
Read more >
Moment.js | Docs
Libraries like Luxon (and others) take advantage of this, reducing or removing the need to ship ... 4 alternatives to moment.js for internationalizing...
Read more >
Libraries & Functions
This library is accessible within the Lambda through the library variable luxon . Here is an example showing how to parse an ISO...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found