Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Provide "YellowStar" as a reusable component.

See original GitHub issue

🗒 General

I noticed YellowStar is a component that is created many times across the code base and thought that it makes sense to either export it from catalog-react alternative keep the color in the theme? I see the change of the color is changed in multiple places already and it would be nice to keep it consistent.

https://github.com/backstage/backstage/blob/b6af1b73fcd5774d5f4b29860c3844b214018df6/plugins/catalog-react/src/components/FavoriteEntity/FavoriteEntity.tsx#L29-L33

https://github.com/backstage/backstage/blob/8f16051d466e21d6d33f2b5b47f32fb8ec911dad/plugins/techdocs/src/home/components/Tables/actions.tsx#L24-L28

https://github.com/backstage/backstage/blob/e1460a97c64a7ed7283f8363e82fca9eb6e0f44b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx#L56-L60

💻 Usage

In any situations where I would like to use a star icon, just visually or with functionality (Button).

Issue Analytics

State:
Created a year ago
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

djamailecommented, Apr 20, 2022

@Rugvip feel free to merge for now, currently on vacation. Will be back in the week of 2nd of May, will put this issue on my list 👍

0reactions

github-actions[bot]commented, Aug 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.