Reviewers Wanted!
See original GitHub issueWe are looking for your help reviewing incoming pull requests to community plugins. There is a constant stream of contributions to our community plugins and we are looking for contributors to help us out reviewing these changes. If you have created, made contributions to, or used an existing plugin, then you can help the community by reviewing incoming changes!
I’m not an experienced reviewer
No one is perfect at code reviews but more eyes on pull requests lead to less bugs, mistakes and in the end better code! Your stamp of approval will count as another signal for the maintainers ultimately merging the pull request. Pre-approved pull requests are much more likely to be reviewed and merged quicker.
What if I don’t have enough time?
No worries. Your life isn’t going to change being a code owner, the primary difference is that you will get notified about changes by Github automatically instead of having to manually scan for incoming PRs.
Does it mean I can merge code if I think it looks good?
Not initially as we want to make sure that everything runs smoothly and cannot be abused.
Suggested Codeowners
We’ve run through the plugins that we currently have in the monorepo and picked a few key contributors that we think would be a great fit for Codeowners and be the first point of contact when it comes to changes to the plugins. Of course, we’re not going to force you to commit to doing it, but it would be great if you think there’s someone else that you could nominate instead 🙏
If your name isn’t listed in the suggestions, but still feel like you would be a great fit for reviewing code changes in a particular plugin then feel free to skip to the next section and raise a PR adding yourself! 😃
plugin name | suggested reviewers + codeowners |
---|---|
allure |
@deepak-bhardwaj-ps |
api-docs |
@fox32 |
app-backend |
@backstage/maintainers |
auth-backend |
@backstage/maintainers |
azure-devops |
@awanlin @marleypowell |
azure-devops-backend |
@awanlin @marleypowell |
azure-devops-common |
@awanlin @marleypowell |
badges |
@kaos |
badges-backend |
@kaos |
bazaar |
@lykkeaxlin @klaraab |
bazaar-backend |
@lykkeaxlin @klaraab |
bitrise |
@petergrau |
catalog |
@backstage/maintainers |
catalog-backend |
@backstage/maintainers |
catalog-backend-module-ldap |
@backstage/maintainers |
catalog-backend-module-msgraph |
@fox32 |
catalog-graph |
@fox32 |
catalog-graphql |
@backstage/maintainers |
catalog-import |
@dhenneke |
catalog-react |
@backstage/maintainers |
circleci |
@andrewthauer |
cloudbuild |
@ebarriosjr |
code-coverage |
@alde |
code-coverage-backend |
@alde |
config-schema |
@backstage/maintainers |
cost-insights |
@silver-lining |
explore |
@fox32 |
explore-react |
@fox32 |
firehydrant |
@hizegi |
fossa |
@dhenneke |
gcp-projects |
@ebarriosjr |
git-release-manager |
@erikengervall |
github-actions |
@backstage/maintainers |
github-deployments |
❓ |
gitops-profiles |
@chanwit |
graphiql |
@backstage/maintainers |
graphql-backend |
@backstage/maintainers |
ilert |
@yacut |
jenkins |
@timja @ashirley |
jenkins-backend |
@timja @ashirley |
kafka |
@nirga @andrewthauer |
kafka-backend |
@nirga @andrewthauer |
kubernetes |
@mclarke47 @backstage/maintainers |
kubernetes-backend |
@mclarke47 @backstage/maintainers |
kubernetes-common |
@mclarke47 @backstage/maintainers |
lighthouse |
❓ |
newrelic |
❓ |
org |
@lewtakm |
pagerduty |
@backstage/maintainers |
permission-backend |
@backstage/maintainers |
permission-common |
@backstage/maintainers |
permission-node |
@backstage/maintainers |
proxy-backend |
@dhenneke |
rollbar |
@andrewthauer |
rollbar-backend |
@andrewthauer |
scaffolder |
@backstage/maintainers |
scaffolder-backend-module-rails |
@angeliski |
scaffolder-backend-module-yeoman |
@pawelmitka |
scaffolder-backend-module-cookiecutter |
@backstage/maintainers |
search-backend-module-elasticsearch |
@xantier |
search-backend-module-pg |
@fox32 |
sentry |
@rodiongork |
sentry-backend |
@rodiongork |
shortcuts |
@backstage/maintainers |
sonarqube |
@dhenneke |
splunk-on-call |
@taitken-splunk |
tech-insights-backend |
@xantier |
tech-insights-backend-module-jsonfc |
@xantier |
tech-insights-common |
@xantier |
tech-insights-node |
@xantier |
tech-radar |
@backstage/maintainers |
todo |
@backstage/maintainers |
user-settings |
@backstage/maintainers |
xcmetrics |
@ngranander |
How do I add myself?
Simple, raise a PR against .github/CODEOWNERS
adding yourself to an existing plugin in the list or create a new line for the plugin of your interest. It’s important to have @backstage/reviewers
as the first entry in the list of owners and then your username.
/plugins/plugin_name @backstage/reviewers @username
Issue Analytics
- State:
- Created 2 years ago
- Reactions:13
- Comments:17 (15 by maintainers)
@Rugvip here you go:
Closing this issue now. Help and review support is still welcome of course ❤️