holdWhen and pausable streams

Hello! Recently, I decided to use holdWhen method in production code for making a pauseable stream (Bacon.repeatedly-based sequence), and, sadly, encountered a trouble that source stream releases lots of values which were buffered when it was ‘paused’. The behaviour I expected was just resuming the sequence from the pause point , without firing lots of buffered values. An example below:

# 'pauser' property
pauseP = $stopper.asEventStream("click").scan(true, (a,b) -> b = !a)
# image sequence
images = $container.find("img").get()
Bacon.repeatedly(100, images)
.holdWhen(pauseP.not())
.assign reloadImage

[phadej]

shouldn’t it be

pauseP = $stopper.asEventStream("click").scan(true, (a,b) -> b == !a) # comparison, not assignment

or if it just inverting than just

pauseP = $stopper.asEventStream("click").scan(true, (a,b) -> !a)

But to answer your question, do you want filter?

pauseP: f-------t---f---
trig  : -1-2-3-4-5-6-7-8-
result: -1-2-3-4-----7-8--

with holdWhen you get

pauseP: f-------t---f---
trig  : -1-2-3-4-5-6-7-8-
result: -1-2-3-4----#7-8--, # is 5 and 6

or do you want:

pauseP: f-------t---f---
trig  : -1-2-3-4-5-6-7-8-
result: -1-2-3-4----5-6-7-8--,

[raimohanska]

Well, I just merged #324 so you’ve got bufferingThrottle and holdWhen. Enjoy bacon.js 0.7.13!