Upgrading from 1.10.7 -> 1.10.8 breaks on node v8.9.4
See original GitHub issueRunning with node v.8.9.4 and start-server-and-test 1.10.8 I’m getting errors related to timedPromise.finally is not a function
. 1.10.7 and earlier does not have this issue.
{ TypeError: Command failed: ./node_modules/.bin/jest ./.storybook/test_image/storyshotImageCompare.optional.test.js
timedPromise.finally is not a function
at setExitHandler (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/execa/lib/kill.js:102:29)
at execa (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/execa/index.js:100:22)
at runTests (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/src/index.js:99:12)
at tryCatcher (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/promise.js:547:31)
at Promise._settlePromise (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/promise.js:604:18)
at Promise._settlePromise0 (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/promise.js:649:10)
at Promise._settlePromises (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/promise.js:729:18)
at _drainQueueStep (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/async.js:93:12)
at _drainQueue (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/async.js:86:9)
at Async._drainQueues (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/async.js:102:5)
at Immediate.Async.drainQueues [as _onImmediate] (/Users/filmfreeway/RubymineProjects/filmfreeway/node_modules/start-server-and-test/node_modules/bluebird/js/release/async.js:15:14)
at runCallback (timers.js:789:20)
at tryOnImmediate (timers.js:751:5)
at processImmediate [as _immediateCallback] (timers.js:722:5)
originalMessage: 'timedPromise.finally is not a function',
shortMessage: 'Command failed: ./node_modules/.bin/jest ./.storybook/test_image/storyshotImageCompare.optional.test.js\ntimedPromise.finally is not a function',
command: './node_modules/.bin/jest ./.storybook/test_image/storyshotImageCompare.optional.test.js',
exitCode: undefined,
signal: undefined,
signalDescription: undefined,
stdout: undefined,
stderr: undefined,
failed: true,
timedOut: false,
isCanceled: false,
killed: false }
and
running tests using command "./node_modules/.bin/jest ./.storybook/test_image/storyshotImageCompare.optional.test.js"
(node:76689) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: timedPromise.finally is not a function
(node:76689) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:5
- Comments:7 (2 by maintainers)
Top Results From Across the Web
Update Now! Node.js 8 is Not Supported from 2020.
Node 8 won't get any more updates from 2020. ... To make sure you don't break your production app follow these steps to...
Read more >npm WARN npm npm does not support Node.js v9.1.0
It turns out that the current installed npm is not compatible with the new node and has a hard time updating. The solution...
Read more >Upgrading from 1.10 to 2 - Apache Airflow
1. Most breaking DAG and architecture changes of Airflow 2.0 have been backported to Airflow 1.10.15. This backward-compatibility does not mean that 1.10.15 ......
Read more >Upgrade Notes | TeamCity On-Premises Documentation
SVNKit was updated to 1.10.7, which resulted in a problem with svn+ssh roots ... Breaking change for Linux Docker images of TeamCity Server: ......
Read more >OpenNMS Release Notes
Node Label Change form Broken (Issue NMS-9414) ... Jetty 9.4 Upgrade: Jetty has been upgraded from 8.1 to the latest 9.4 . If...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
🎉 This issue has been resolved in version 1.10.9 🎉
The release is available on:
npm package (@latest dist-tag)
Your semantic-release bot 📦🚀
I’ve just installed this library for the first time and ran into the same problem.
As upgrading node isn’t a solution for me, I’ve downgraded this library from
1.10.8
to1.10.7
, and that fixed the problem.A breaking change in a patch version isn’t very nice. I can imagine that some users will run into problems because of this.