connect-pg-simple takes 10s to shutdown

Node version: 10.16.0 Sails version (sails): 1.2.3 ORM hook version (sails-hook-orm): DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql 1.0.2

---

connect-pg-simple takes 10s to shutdown at the end of tests.

Example project at: https://github.com/alxndrsn/sailsjs-connect-pg-simple-shutdown-delay

To recreate:

git clone https://github.com/alxndrsn/sailsjs-connect-pg-simple-shutdown-delay
cd sailsjs-connect-pg-simple-shutdown-delay

$ yarn test
...
  connect-pg-simple leaves a hanging promise
    ✓ leaves a hanging promise...


  1 passing (542ms)

Done.
Done in 11.73s.

$ IN_MEMORY_SESSIONS=true yarn test
...
  connect-pg-simple leaves a hanging promise
    ✓ leaves a hanging promise...


  1 passing (530ms)

Done.
Done in 1.70s.

[alxndrsn]

This also prevents sails console or sails lift from shutting down quickly.

Again this can be worked around by calling sails.config.session.store.close(); in the callback from sails.lift() in app.js:

// Start server
sails.lift(rc('sails'), err => {
  if(err) {
    console.error('Failed to lift app:', err);

    try {
      sails.config.session.store.close();
    } catch(err2) {
      console.error('Error caught trying to shut down postgres session store:', err2);
    }

    return;
  }

  sails.log.verbose('App lifted successfully.');
});

[alxndrsn]

It seems you can work around this by manually destroying the session postgresql pool, using sails.config.session.store.close();.

In the example project, this can be done by changing test/config.js to:

const sails = require('sails');

before(done => {
  sails.lift({}, err => {
    if (err) { return done(err); }
    return done();
  });
});

after(done => {
  sails.lower(() => {
    sails.config.session.store.close();
    done();
  });
});