Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

What's about reworking MaterialDialogs.ShowAlertAsync to make it really awaitable and return Task<bool> instead?

See original GitHub issue

Hi!

I’ve tried also MaterialDialogs.ShowAlertAsync which works fine in general. However, with current implementation I can’t see a way of notifying when the alert (confirmation) box is closed with negative (cancelling) result.

Currently the method is (in general) awaitable, which completes on the confirm popup appearing, however, usually, it doesn’t have much sense from the app logic functionality perspective. From my experience, it’s rather more important to be able further processing of the app logic after the choice been done.

So, I would suggest to rework it to return Task<bool>, which would complete after the used made his choice.

What do you think? I can also fork and apply that update as well if you have no time for that.

Issue Analytics

State:
Created 5 years ago
Comments:6

Top GitHub Comments

1reaction

contrix09commented, Sep 3, 2018

I can also fix that. I set it to 40 since it was the recommended height, but I forgot to consider long titles.

BTW, thanks for raising these issues/suggestions.

0reactions

contrix09commented, Sep 5, 2018

Version 1.0.6 has been released, adding MaterialDialogs.ShowConfirmAsync() which returns Task<bool>. Also, the title of the alert dialog now breaks line when it is long.