Avoid sending brightness changes, when no changes are to be made

This component works great, so thanks for that 😃

One minor change though - it seems brightness is being set, even when no change is made. F.ex, I will often see changes being pushed to lights going from 15% brightness to 15% brightness… HASS does not seem to check if the brightness has changed, before sending the command out…

Could Adaptive Lighting be updated to check if there’s a change, before calling light_on ? 😃

Thanks in advance.

[sphanley]

That seems like good insight, but I feel like we’ve totally hijacked this original issue. Maybe a new issue should be opened for the dimming-brightening cycle issue?

[RouNNdeL]

I believe that both Shelly issues are caused by an event with brightness_pct: 0 being called (I don’t know where this comes from, it was in the logs). Here’s a script that replicates both the blinking and the transition canceling:

alias: Test
sequence:
  - service: light.turn_on
    data:
      brightness_pct: 0
    entity_id: light.bedroom
  - service: light.turn_on
    entity_id: light.bedroom
  - service: light.turn_on
    data:
      brightness_pct: 50
    entity_id: light.bedroom
mode: single

This exact sequence I found in the logs, all of this happens very quickly.

Interestingly enough removing the brightness_pct service call fixes the blinking problem, but removing the service all without any data fixes the transition problem.

Transition working:

alias: Test
sequence:
  - service: light.turn_on
    data:
      brightness_pct: 0
    entity_id: light.bedroom
  - service: light.turn_on
    data:
      brightness_pct: 50
    entity_id: light.bedroom
mode: single

No blinking:

alias: Test
sequence:
  - service: light.turn_on
    entity_id: light.bedroom
  - service: light.turn_on
    data:
      brightness_pct: 50
    entity_id: light.bedroom
mode: single