Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Windows, native launcher: sh_binary doesn't have `rlocation`

See original GitHub issue

When using the native launcher, the .exe launcher created from sh_binary rules doesn’t define rlocation for the shell script.

Normally rlocation is defined for shell tests because they all run https://github.com/bazelbuild/bazel/blob/master/tools/test/test-setup.sh which defines and exports this function.

Issue Analytics

State:
Created 6 years ago
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

laszlocsomorcommented, Oct 9, 2017

Actually, I like your idea more than my own! Let me accommodate that in my CL.

0reactions

laszlocsomorcommented, May 2, 2018

I’m closing this bug as obsolete.

The sh_binary on non-Windows uses no launcher, so there’s nothing to load whatever defines rlocation. If users want to write platform-independent sh_* rules, they’ll need to source the rlocation-defining library manually (copy-pasting the code to do so from the runfiles library itself).

Automatically sourcing the file on Windows encourages writing non-portable Bash scripts, and is unnecessary if the scripts will have the copy-pasted initializer code anyway.