Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FR: Use configurable buildozer + buildifier for BUILD file modify + formatting

See original GitHub issue

For build file modification the plugin uses simple text modifier

For build file formatting the plugin uses hardcoded version of buildifier. Currently set to 0.12.0 when the last released version is 0.20.0

We should use buildozer for modifications and allow configuring local binaries

Feature requests:

Use buildozer for build file modification. Have a built-in buildozer binary as well. Change buildModifier to drive the binary and not change text manually. (note: buildozer expects to find buildifier on PATH, but I’m sure we can solve it, eg: modifying the PATH according to configured buildifier)
Allow overriding the built-in tools by providing path to locally installed tools (so we can use newer versions). We already have configuration for bazel binary - let’s add configuration for those tools as well.

Issue Analytics

State:
Created 5 years ago
Reactions:7
Comments:8 (1 by maintainers)

Top GitHub Comments

1reaction

ignaslcommented, Feb 21, 2019

Another use-case for having buildifier and buildozer configuration is that on MacOS X (at least on 10.14) /usr/local/bin does not appear in PATH that Java gets from environment and this is where these tools would normally be installed if access to /usr/bin, `/bin’ or other system folders is restricted.

0reactions

kylecordescommented, Dec 1, 2019

I notice this issue starkly while switching back and forth between this plugin and VScode with its plugin… which (while not without its own open issues) “just works” with the buildifier already on the PATH.