question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

7.1.1-7.1.2 seems to break coverage reporting on macos/ubuntu/windows with Node 10 (only)

See original GitHub issue
  • Version: 7.1.2
  • Platform: ubuntu-latest/Node 10

https://github.com/DavidAnson/markdownlint runs c8 against master every day. After 10 successful runs with no changes to that branch, it started failing yesterday: https://github.com/DavidAnson/markdownlint/actions?query=workflow%3ACI

I created a fork of master with c8 locked to 7.1.1: https://github.com/DavidAnson/markdownlint/tree/c8711

It passes: https://github.com/DavidAnson/markdownlint/actions/runs/98587182

I created a fork of master with c8 locked to 7.1.2: https://github.com/DavidAnson/markdownlint/tree/c8712

It fails: https://github.com/DavidAnson/markdownlint/actions/runs/98587661

To be clear, that is the only difference between the branches:

pi@claw:~/markdownlint $ git diff c8711..c8712
diff --git a/package.json b/package.json
index 1edc8d0..d16356a 100644
--- a/package.json
+++ b/package.json
@@ -35,7 +35,7 @@
   "devDependencies": {
     "@types/node": "~13.11.1",
     "browserify": "~16.5.1",
-    "c8": "7.1.1",
+    "c8": "7.1.2",
     "cpy-cli": "~3.1.0",
     "eslint": "~6.8.0",
     "eslint-plugin-jsdoc": "~22.1.0",

GitHub aggressively terminates Actions with a failure, but this run demonstrates that the same 7.1.2 that fails on ubuntu-latest/Node 10 passes on ubuntu-latest/Node 14: https://github.com/DavidAnson/markdownlint/actions/runs/98145382

The relevant command is: c8 --check-coverage --branches 100 --functions 100 --lines 100 --statements 100 node test/markdownlint-test.js. In the failure case, it reports 4 lines uncovered: helpers.js | 99.4 | 96.35 | 100 | 99.4 | 156,194,197,554

The corresponding file: https://github.com/DavidAnson/markdownlint/blob/c8712/helpers/helpers.js

The first of the corresponding lines: https://github.com/DavidAnson/markdownlint/blob/34e2fd057648fda7559185e9aeaa68284f0d359b/helpers/helpers.js#L156

Please let me know if you need anything else from me.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
DavidAnsoncommented, May 11, 2020

Just FYI, my thinking is to update the Workflow thusly:

- name: Run All Validations
  if: ${{ matrix.node-version != 10.x }}
  run: npm run ci
- name: Run Tests Only
  if: ${{ matrix.node-version == 10.x }}
  run: npm run test
0reactions
bcoecommented, May 11, 2020

@DavidAnson I think it would be good to add a section to the README that covers this topic, it’s definitely confusing that the engine matters so much.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Coverage reporting is broken #24966 - nodejs/node - GitHub
The coverage report from the last couple of days is broken (see https://coverage.nodejs.org). I guess it's related to the V8 update.
Read more >
Switching between Node versions during development
We compare and contrast two popular Node version managers that can help you more easily switch between Node versions during development.
Read more >
NVM for Windows not working? - node.js - Stack Overflow
Solution: After uninstalling node, make sure the directory where node was originally installed has been removed and not just empty. For Windows 7...
Read more >
The Difference Between Node.js 10 LTS and Node.js 12 LTS
It returns resource usage for the current process, such as CPU time #28018. report: An experimental diagnostic API for capturing process state ...
Read more >
Update the Node.js agent | New Relic Documentation
json , run npm install . If you want to target just the newrelic module, run npm update newrelic . Recommendation: Test your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found