missing coverage of closing brace when `return` ends a `switch/case`

• Version: tested on 8.15.1, 10.15.3, 11.14.0, 12.0.0, 13.0.0-pre
• Platform: Darwin Fhqwhgads.local 17.7.0 Darwin Kernel Version 17.7.0: Wed Feb 27 00:43:23 PST 2019; root:xnu-4570.71.35~1/RELEASE_X86_64 x86_64

Code in foo.js:

function checkIt(arg) {
  switch (arg) {
    case true:
      return 'It was true!';
    case false:
      return 'It as not true';
  }
  return 'It was neither true nor false';
}

const val1 = checkIt(true);
const val2 = checkIt(false);
const val3 = checkIt('string');

console.log(val1);
console.log(val2);
console.log(val3);

Command:

c8 node foo.js

Output:

It was true!
It as not true
It was neither true nor false
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |    94.12 |    71.43 |      100 |    94.12 |                   |
 foo.js   |    94.12 |    71.43 |      100 |    94.12 |                 7 |

Expected output:

I expected to see 100% coverage...

[bcoe]

@Trott hey, I remember this bit of the codebase,

https://github.com/v8/v8/commit/deac757bc76d207845375340bcea090c774ad9d0

Let’s cherry-pick that commit 😄

[Trott]

I think this has been fixed in V8 although awaiting a release?