Relocations are broken

It appears that relocations are currently being applied incorrectly. For example, in Dark Cloud, in EscapeDungeonMode there should be a jump to SearchItemIndexNo like this:

001f3f58 50 f6 06 0c jal CDngStatusData::SearchItemIndexNo undefined SearchItemIndexNo(int param_1)

However, instead, the jump is to an invalid address like this:

001f3f58 a0 ec 0d 0c jal SUB_0037b280

If you look in Ghidra’ relocation table view, you can see that this is due to a relocation at this address (which is incorrect):

001f3f58 0x4 0x2c1d 50 f6 06 0c SearchItemIndexNo__14CDngStatusDataFi

Both IDA and ps2dis do not alter the initial value and produce correct results. This can be seen in a number of other places too, but I picked one example for convenience.

[astrelsky]

I look forward to this fix.

The fixes won’t come until the release of ghidra 9.2. There was an issue with extension points that has since been resolved. I also need to do some major cleanup and reorganization but hopefully it shouldn’t be to long.

[astrelsky]

Okay. Apologies for uploading the binary.

In terms of 9.2, if you could make a separate branch, that would be good enough. I’m willing to build Ghidra 9.2 if it would let me start reversing this binary. As far as I’m aware there’s no indication for when 9.2 will officially be released, and it’s been 8 months since the last release. I hate to be pushy like this, but I’m getting a little frustrated with how long it’s taken to release.

You may give this a shot. I won’t put it up in a branch until I’ve removed the unused code and figure out how I want to handle the irx modules.

ghidra_9.2_DEV_20201005_ghidra-emotionengine.zip