in keyword in class method causes indentation problem

Description

Class with a function named “in” causes indentation issue:

Input

The code looked like this before beautification:

class {
  get a() {

  }

  in () {

  }

  b () {

  }
}

Expected Output

The code should have looked like this after beautification:

(should be unchanged)

Actual Output

The code actually looked like this after beautification:

class {
    get a() {

        }

        in () {

        }

    b() {

    }
}

Steps to Reproduce

Tried on https://beautifier.io/

[kcamsanc]

If so, what’s the best way to reproduce this error in the Python implementation after forking and cloning the repo locally? Thanks.

I believe I figured out the answer to my question above.

I am now working on this change. I will keep you all updated on my progress!

[kcamsanc]

Did you run make all? I’d be very surprised if that didn’t generate the test for both js and python, and result in a failure in the python test run.

Yes, to test this, I reverted my changes to tokenizer.py and ran both make and make all (not sure if there’s a difference there). Neither resulted in a failure, and within the make all output, I do see:

...
Test unpack() function. ... ok
test_detect (jsbeautifier.unpackers.tests.testurlencode.TestUrlencode)
Test detect() function. ... ok
test_unpack (jsbeautifier.unpackers.tests.testurlencode.TestUrlencode)
Test unpack function. ... ok

----------------------------------------------------------------------
Ran 36 tests in 0.056s

which I think means that no Python tests failed even after I reverted my changes in tokenizer.py. I also ran make py, which resulted in “PASSED”.

Looking into this further, I can actually see that my unit tests were automatically generated inpython/jsbeautifier/tests/generated/tests.py like you said, so I feel like it’s strange that no Python tests failed. FWIW, I know the JavaScript unit tests I wrote failed before I made changes to the JavaScript implementation.

I know I can’t make changes to python/jsbeautifier/tests/generated/tests.py as it is automatically generated. So, what’s the best way to write good unit tests to make sure this bug doesn’t reoccur in the future? (For now, like I mentioned, I’ve just had to run ./tools/python-dev js-beautify on a local .js file I made to see if the bug is still present in the Python implementation.)