Specs got stuck in the end

I’m using superagent-mock to mock my requests and, even returning the correct result and the tests are passing, after all specs are done, the suite got stuck and release after 60s (probably a timeout).

Disabling superagent-mock makes all the specs to pass (hitting the real server), and the suite finishes instantly.

Below is my spec:

  describe('search triggers', () => {
    const mockObj = superagentMock(request, rules)

    describe('city search', () => {
      beforeEach(() => triggerSearchByCity())

      it('should update the state', () => {
        expect(subject.state.loaded).toEqual(true)
        expect(subject.state.data).toEqual(apiMocks.cityResponse)
      })
    })

And my mock setup rules:

 rules= [{
    pattern: 'http://api.openweathermap.org/data/2.5/weather(.*)',

    
    fixtures: function (match, params, headers, context) {
      // City search mock
      if (match[1] === '?q=Berlin%2CDE&units=metric&APPID=[MY APP ID]') {
        return cityResponse
      }

    get: function (match, data) {
      return {
        body: data
      };
    }
  }
];

And my superagent call:

  return new Promise((resolve, reject) => {
    request
      .get('http://api.openweathermap.org/data/2.5/weather')
      .query({
        q: `Berlin,DE`,
        units: 'metric',
        APPID: '[My APP ID]'
      })
      .end((err, res) => {
        if (err) { reject (err)      }
        else     { resolve(res.body) }
      })
  })

The promise above is resolved in the triggerSearchByCity() method.

UPDATE: Here’s another simpler setup that causes the same problem: https://gist.github.com/mauricioklein/b0dd5768bce0075232729596dc71a83f

Thanks!

[daldridge-cs]

I had the same issue, and switched to superagent-mocker, which handles superagent’s RequestBase::then() correctly. Tests that hung Mocha with superagent-mock, no longer hung when using superagent-mocker (tests stayed exactly the same, only the before/after hooks were modified to use the other mocking library).

[y-nk]

@fdubost not sure why issue is closed. it’s still happening.

i’ve pinpointed to this particular moment https://github.com/M6Web/superagent-mock/blob/master/src/superagent-mock.js#L237-L242 where the setTimeout is never called ; but not sure why. It’d be great to fix it.