Aggregate exceptions

Great library! Biggest problem with doing good work is people raise awkward questions! Sorry.

What’s the best way to handle AggregateExceptions? I’m using Service Fabric and Serilog for all my logging. Lots of cross service exceptions are exposed as AggregateExceptions and they still produce a generally old fashioned stack trace.

I’ve got something working by just logging the inner exception, but that seems like I’m handling the problem at the wrong level. I think Demystify should handle the aggregate exception internally.

This change in Demystify may work - does it make sense?

                if (exception is AggregateException aex)
                {
                    foreach (var innerException in aex.InnerExceptions)
                    {
                        innerException.Demystify();
                    }
                }
                else
                {
                    exception.InnerException?.Demystify();
                }

[nrandell]

Much better - thanks for the quick response! Wish I had this a few years ago.

System.OperationCanceledException: Aborted ---> Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Unexpected end of request content.
   at void Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines.PipeCompletion.ThrowFailed()
   at void Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines.Pipe.GetResult(ref ReadResult result)
   at ReadResult Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines.Pipe.Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines.IReadableBufferAwaiter.GetResult()
   at async Task<int> Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.ReadAsync(ArraySegment<byte> buffer, CancellationToken cancellationToken)
   at async Task<int> Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameRequestStream.ReadAsyncInternal(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
   at async Task System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(int minimumRequiredBytes, CancellationToken cancellationToken, bool throwOnPrematureClosure)
   at async Task<WebSocketReceiveResult> System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate(ArraySegment<byte> payloadBuffer, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at async Task<WebSocketReceiveResult> System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate(ArraySegment<byte> payloadBuffer, CancellationToken cancellationToken)
   at async Task PlatformWebApi.Sockets.WebSocketConnection.RunAsync() in C:\Users\nick\Source\Repos\SceneSkopePlatform\PlatformWebApi\Sockets\WebSocketConnection.cs:line 56
   at async Task PlatformWebApi.Startup.RunWebSocketAsync(WebSocket webSocket, HttpContext context) in C:\Users\nick\Source\Repos\SceneSkopePlatform\PlatformWebApi\Startup.cs:line 87
   at async Task PlatformWebApi.Sockets.WebSocketHandler.AcceptAsync(HttpContext context) in C:\Users\nick\Source\Repos\SceneSkopePlatform\PlatformWebApi\Sockets\WebSocketHandler.cs:line 29
   at async Task Microsoft.AspNetCore.ResponseCompression.ResponseCompressionMiddleware.Invoke(HttpContext context)
   at async Task Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.Invoke(HttpContext context)
   at async Task PlatformWebApi.SerilogMiddleware.Invoke(HttpContext httpContext) in C:\Users\nick\Source\Repos\SceneSkopePlatform\PlatformWebApi\SerilogMiddleware.cs:line 37
   at async Task Microsoft.ServiceFabric.Services.Communication.AspNetCore.ServiceFabricMiddleware.Invoke(HttpContext context)
   at async Task Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.Invoke(HttpContext httpContext)
   at async Task Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame<TContext>.ProcessRequestsAsync()

[benaadams]

Version 0.0.4 is on NuGet https://www.nuget.org/packages/Ben.Demystifier/0.0.4